Skip to content

wip #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

wip #1961

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
984dc64
wip upgrade to plotly.js 2.0
cpsievert Jun 8, 2021
053e70b
patch plotly.js source to support phantomjs/shinytest
cpsievert Jun 8, 2021
416c9d1
bump mathjax version
cpsievert Jun 8, 2021
8e4bf05
use npm instead of yarn
cpsievert Jun 9, 2021
843be11
make geom_bar() default to textposition='none'; approve new vdiffr 0.…
cpsievert Jun 9, 2021
fed976d
Migrate to vdiffr 1.0
cpsievert Jun 9, 2021
d683852
wip migrate to gha
cpsievert Jun 10, 2021
f6e2b5c
Skip plotly cloud API tests on everything but Windows r-release
cpsievert Jun 17, 2021
db48488
finish migrating cloud skip logic
cpsievert Jun 17, 2021
fb5d2ef
a start on porting dockerfile to gha
cpsievert Jun 17, 2021
4a1ee07
use a similar skipping strategy for shinytest
cpsievert Jun 17, 2021
e7dee15
fix helper logic
cpsievert Jun 17, 2021
2310c7d
Use layout.legend.title over layout.annotations to when converting gu…
cpsievert Jun 17, 2021
dba2a47
fix shinytest skip logic
cpsievert Jun 17, 2021
de8d849
update legend conversion test expectations
cpsievert Jun 17, 2021
4f2e432
get orca installed
cpsievert Jun 17, 2021
1d53bde
maybe chrome won't be needed
cpsievert Jun 17, 2021
e429219
pls
cpsievert Jun 17, 2021
d44dc5c
pls
cpsievert Jun 17, 2021
566a578
pls
cpsievert Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use npm instead of yarn
  • Loading branch information
@cpsievert
cpsievert committed Jun 17, 2021
commit 8e4bf05e285092f8e472b572c01bf6dfd07abfcc
22 changes: 9 additions & 13 deletions inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions tools/update_plotlyjs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ withr::with_dir(tmpdir, {
)
}

# build
system("yarn install")
system("yarn build")
# build just the main bundle
# (also builds schema and locales)
system("npm install")
system("npm run bundle")

# copy assets to R package source
file.copy(
Expand Down