-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Allow legend to use bottom margin space? #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds like a solid idea 👍 I'd vote for adding a // for vertical legends
layout.height - (layout.margin.t + layout.margin.b)
// for horizontal legends
layout.width - (layout.margin.l + layout.margin.r) This layout = {
len: 1.2
} which would make the legend span into the bottom margin. |
To achieve the effect I showed, I had modified:
I think gs.h works out to Would you recommend that (roughly):
|
@rpaskowitz yep, that sounds about right. Would you mind making a PR so that we can test this solution in detail? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
+1 for a |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
Would the team accept a PR to optionally allow the legend to expand in to the bottom margin area?
Currently this space is un-used since there will never be x-axis labels in this place, and it would allow for more legend entries to be shown before scrolling.
Visually, some people may prefer to have the legend entries align entirely with the graph area, but in my case, it would be preferable to use the space to show more.
Here is an example of the legend_scroll mock with 100% of the bottom margin used. (I'd probably preserve some margin, also maybe configurable so it doesn't go right to the bottom of the div).
The text was updated successfully, but these errors were encountered: