Skip to content

Responsive config option does not apply on elements size changes #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ioannis-kokkalis opened this issue Jul 21, 2024 · 1 comment
Open
Labels
bug something broken P2 considered for next cycle

Comments

@ioannis-kokkalis
Copy link

Hello, I have some issues with responsiveness when using CSS grid and I put charts on it. Searching further, my problem should be equivalent to charts do not get notified for parent size changes and do get notified only for window size changes.

I found this closed issue #3984 and the last comment mentions to open a new related one. From reading the comments there, the problem was:

there is no way to be notified when an element changes size

Since some time has passed and ResizeObserver is well supported from what I'm checking, I think this is an addressable issue. On this comment of issue #3984 is a proof of principle (or/and workaround) using ResizeObserver and I had already created an example in codepen that demonstrates my issue. Also issue #5396 seems to be related I believe.

In codepen example I do use version 2.34.0 which is the current latest, to remember it instead of putting just latest. I did enable template so anyone can test it with other versions if needed.

Available to provide further details when/if necessary.

@gvwilson gvwilson assigned gvwilson and unassigned gvwilson Jul 26, 2024
@gvwilson gvwilson changed the title Responsive config option does not apply on elements size changes. Responsive config option does not apply on elements size changes Aug 9, 2024
@gvwilson gvwilson added bug something broken P2 considered for next cycle labels Aug 9, 2024
@lesteve
Copy link

lesteve commented Feb 7, 2025

FWIW it seems like we were affected by this in https://github.com/scikit-learn/scikit-learn documentation (and other projects around it, for example https://github.com/skrub-data/skrub and https://github.com/probabl-ai/skore).

We have a work-around in place (see scikit-learn/scikit-learn#30279 for the original issue and scikit-learn/scikit-learn#30778 the fix) so there is definitely no emergency here, but it would still be nice if one day this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

3 participants