Skip to content

gl2d image tests (finally) #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 19, 2016
Prev Previous commit
Next Next commit
test: merge gl2d connectgaps & line opacity mocks in one
  • Loading branch information
etpinard committed Oct 13, 2016
commit 0c116dc717c0fa85c5fa5c4aaadf9e3398a8d89c
Binary file modified test/image/baselines/gl2d_connect_gaps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed test/image/baselines/gl2d_line_opacity.png
Binary file not shown.
5 changes: 3 additions & 2 deletions test/image/mocks/gl2d_connect_gaps.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
"y": [-2, -2, null, 2, 2],
"connectgaps": true,
"mode": "lines",
"type": "scattergl"
"type": "scattergl",
"opacity": 0.4
}
],
"layout": {
"title": "Connect gaps test"
"title": "Connect gaps + line opacity test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I see this is one type of new coverage. Btw. indeed the image tests are rather expensive, around 1s each.

}
}
169 changes: 0 additions & 169 deletions test/image/mocks/gl2d_line_style.json

This file was deleted.