Skip to content

Improved animation merging for layout and traces #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 17, 2016
Merged

Improved animation merging for layout and traces #1041

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e86edd
Add failing test fro transition transform
rreusser Oct 14, 2016
a0da51d
Mostly factor out trace and layout merge logic
rreusser Oct 14, 2016
b612ac3
Methods for extendTrace and extendLayout
rreusser Oct 14, 2016
8d35b71
Lock down and document the unimplemented case in expandObjectPaths
rreusser Oct 14, 2016
c93c18f
Verify function of animated transforms
rreusser Oct 14, 2016
33e23db
Tweak trivial things to get the test to pass
rreusser Oct 14, 2016
511de3d
Delete best guess at failing test
rreusser Oct 14, 2016
adee9b2
Add missing layout container arrays
rreusser Oct 17, 2016
e085a53
Add additional docs on expandObjectPaths subtleties
rreusser Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing layout container arrays
  • Loading branch information
@rreusser
rreusser committed Oct 17, 2016
commit adee9b291ed07bf94e5aabed760135c90b5a2c55
5 changes: 4 additions & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,10 @@ plots.extendTrace = function(destTrace, srcTrace) {
plots.extendLayout = function(destLayout, srcLayout) {
return plots.extendObjectWithContainers(destLayout, srcLayout, [
'annotations',
'shapes'
'shapes',
'images',
'sliders',
'updatemenus'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

]);
};

Expand Down