Modify Plotly.plot to accept frames #1014 #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Oct 18, 2016
| @@ -330,6 +346,7 @@ Plotly.plot = function(gd, data, layout, config) { | |||
| Lib.syncOrAsync([ | |||
| Plots.previousPromises, | |||
| drawFramework, | |||
| addFrames, | |||
There was a problem hiding this comment.
Ah, got it. Plots.supplyDefaults(gd); is called synchronously in the above function body so yeah, switching those two should be fine.
There was a problem hiding this comment.
(Of course you could now ask the opposite question, but I think loading data first is nicer.)
etpinard
reviewed
Oct 18, 2016
| layout: {width: 500, height: 500}, | ||
| config: {editable: true}, | ||
| frames: [{y: [2, 1, 0], name: 'frame1'}] | ||
| }).then(function() { |
There was a problem hiding this comment.
@rreusser does
Plotly.plot(gd, {
data: [],
frames: [ /* some initial list of frames */ ]
})
.then((gd) => {
// add more frames!!
Plotly.addFrames(gd), [ /* more frames !! */ ]);
})work as expected?
There was a problem hiding this comment.
Yup!
Unexpected token )
But srsly, added this test and just pushed.
|
nicely done 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overloads
Plotly.plotso that loading frames isn't a second, promise-chained step.Original (still works)
Variation
Now unnecessary