More syntax tests #1419
Merged
More syntax tests #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- except some .md files and mathjax dist/extras/
- run it on .json image test mocks and .glsl files - no need it to run it on .js files as eslint already takes care of that.
tasks/test_syntax.js
Outdated
| path.join(constants.pathToRoot, 'test', 'image', 'mocks', '*') | ||
| ]); | ||
|
|
||
| var regex = /\r?\n$/; |
There was a problem hiding this comment.
do we want to make sure they end in exactly one newline, no more?
There was a problem hiding this comment.
Ah. Good call. Thanks!
|
Thanks, 💃 Not sure what GH thinks changed in 9f1c6c4#diff-ebde94117620b050ec349c85b9a200ea but anyway it all looks good. |
I think that's because my vim changed the DOS EOL to a UNIX EOL on save. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
\nat end of file for JSON and.glslfiles