Skip to content

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Mar 7, 2017

featuring most notably some uglify-js improvements that will trim our minified bundle size by a few bytes in future releases.

@etpinard
Copy link
Contributor Author

etpinard commented Mar 7, 2017

Very interestingly, bumping uglify-js to 2.8.8 makes some of our gl3d image tests fail

image

gl3d requires uglify-js via the cwise browserify transform.


Pinging scijs pros @rreusser and @dfcreative if you can think of a reason why. See git-compare here.

etpinard added a commit that referenced this pull request Mar 9, 2017
- the new 2.8.x series breaks the `cwise` transform
- see #1450 (comment)
- maybe we should make uglify-js a core dependencies then?
@etpinard
Copy link
Contributor Author

etpinard commented Mar 9, 2017

Putting this PR on hold until we find the root of the cwise + uglify-js@2.8.x problem.

@etpinard
Copy link
Contributor Author

etpinard commented Mar 13, 2017

PR sent upstream ↪️ scijs/cwise#13

On the same topic: scijs/ndarray-fill#2

@etpinard etpinard added this to the v1.25.0 milestone Mar 13, 2017
@etpinard etpinard mentioned this pull request Mar 14, 2017
@etpinard etpinard merged commit 88ccce4 into master Mar 14, 2017
@etpinard etpinard deleted the bump-dev-deps branch March 14, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant