Relayout edge case fixes #1494
Merged
Relayout edge case fixes #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is also done in the default step - but we need to reset it here to get margin relayout calls to not throw excpetions.
- so that they don't throw exceptions with the excepted axis container is undefined.
etpinard
commented
Mar 17, 2017
| @@ -26,6 +26,8 @@ var toLogRange = require('../../lib/to_log_range'); | |||
| * same relayout call should override this conversion. | |||
| */ | |||
| module.exports = function convertCoords(gd, ax, newType, doExtra) { | |||
| ax = ax || {}; | |||
There was a problem hiding this comment.
.. so that e.g. in relayout blank axis objects that pass the forgiving AX_NAME_PATTERN (which also matches zaxis? by the way) don't leave to exceptions.
There was a problem hiding this comment.
cc @alexcjohnson
There was a problem hiding this comment.
Man, if only I could turn back time and not use linearized coordinates on log axes...
etpinard
commented
Mar 17, 2017
| @@ -714,6 +714,7 @@ proto.setConvert = function() { | |||
| for(var i = 0; i < 3; ++i) { | |||
| var ax = this.fullSceneLayout[axisProperties[i]]; | |||
| Axes.setConvert(ax, this.fullLayout); | |||
| ax.setScale = Lib.noop; | |||
There was a problem hiding this comment.
This statement also appears in the 3d axis_defaults.
|
Looks good. I can't really tell if these problems generalize beyond these fixes or not, so I guess if anything else comes up we'll just have to add more test cases... 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits here each fix one relayout edge case broken since #1431 and #1403 respectively.