Make hover spikes work when no tick labels are present #1980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that hover knows where to draw spikes
ea30e30 to
a66aa2d
Compare
|
Looks solid to me. Might want to calculate the rest of the bbox attributes just so people can pretend it's a real bbox (I see one caller that looks for |
- when label position is undefined, don't (re)-calc its bounding box as that could override previous 'correct' calculations (e.g. when overlaying axes are present) - add dummy bounding box value whenever showticklabels is false
alexcjohnson
reviewed
Sep 5, 2017
| .then(function() { | ||
| Fx.hover('graph', {xval: 2, yval: 3}, 'xy'); | ||
| expect(d3.selectAll('line.spikeline').size()).toEqual(4); | ||
| expect(d3.selectAll('circle.spikeline').size()).toEqual(1); |
There was a problem hiding this comment.
is it worth verifying that these things have reasonable dimensions/positions?
There was a problem hiding this comment.
Good call. done in 92b606b
- assert number of spike line visible as well as their position attributes
|
Looks fantastic - thanks for testing positions. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1977 and makes #1604 obsolete.
@alexcjohnson I wouldn't mind a +1 on my approach before I add a test or two.