allow hover labels to extend to the edges of the plot #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not get cut off at the subplot edges box and violin tests had some labels clipped before - now they all get drawn 🎉
I agree. This is a good tradeoff. Nice fix and test 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #527
@etpinard another quick bugfix for you: Allow hover labels to push out not just to the edges of the subplot but to the edges of the graph div.
There's one downside to this fix: The axis label can get partially covered by point labels in certain extreme cases:
The common label is supposed to say "day 1" and the "1" is mostly covered. If this label were much longer, more of it would be hidden. To my mind this is a good tradeoff, as a) the y labels are usually more important, so it's better to show as many of these as you can, and b) you can always switch to "closest" mode to narrow in on what info is displayed.