ignore invalid trace indices in restyle and update #3114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
commented
Oct 16, 2018
| @@ -490,6 +490,9 @@ exports.coerceTraceIndices = function(gd, traceIndices) { | |||
| else if(!Array.isArray(traceIndices) || !traceIndices.length) { | |||
| return gd.data.map(function(_, i) { return i; }); | |||
| } | |||
| else if(Array.isArray(traceIndices)) { | |||
| return traceIndices.filter(function(i) {return i < gd.data.length;}); | |||
| } | |||
There was a problem hiding this comment.
Should I do a Lib.warn('trace indice is not number or is out of bound')?
There was a problem hiding this comment.
That's a good idea - should help users debug, since this really shouldn't happen normally.
indice index is not a number or is out of bounds
Also I guess while we're at it we should filter out non-integers and negative numbers. Oh hey lib.isIndex - accepts strings too but those seem to be OK, ie a=[1,2,3]; a['1']===2
There was a problem hiding this comment.
Hooray for lib.isIndex. I really should spend some time to find out all the functions we have in lib!
also fix attribute in test
|
Thanks for the quick fix @antoinerg ! 🚀 Very nice tests. |
|
🆘 delete branch alert 🆘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3113