implied edits connecting height/width/autosize #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Oct 17, 2018
| // can't use impliedEdits for this because behavior depends on vi | ||
| if(['width', 'height'].indexOf(ai) !== -1) { | ||
| if(vi) { | ||
| doextra('autosize', null); |
There was a problem hiding this comment.
FYI doextra(attr, null) works (with some caveats) just like relayout(gd, attr, null) in that it deletes that attribute from layout
|
Oh hmm, @antoinerg turns out I did impact at least your autosize tests - need to look at whether those failures make sense. |
|
I don't think it interferes with any of my work on |
|
Looks good to me! You can merge it in 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So you can turn autosize back on again, using
relayoutorupdate, after it's been turned off and replaced by explicitheight&width.@antoinerg please review. Shouldn't have any adverse impact on the autosize work you did recently as this only affects edit behavior (and only the older modes, not
react)