Skip to content

Improve rendering of lines in 3D (against disappearing in certain angles) issue #691 #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Improve rendering of lines in 3D (against disappearing in certain angles) issue #691 #3128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1b4c6e9
orient line rectangles properly
archmoj Oct 19, 2018
72ba096
updated baseline images showing improvements of rendering lines in 3D
archmoj Oct 19, 2018
4e8c3ee
new module with mocks and baseline image
archmoj Oct 22, 2018
34ad403
correct baseline image
archmoj Oct 23, 2018
3eba418
improved new mocks - the image based on master
archmoj Oct 25, 2018
8641bed
image using branch to create a diff
archmoj Oct 25, 2018
ad35241
correct baseline image
archmoj Oct 25, 2018
6712a55
revised mock
archmoj Oct 26, 2018
420fe72
new image to show the diff
archmoj Oct 26, 2018
a4d67fd
correct baseline image of the final mock
archmoj Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new module with mocks and baseline image
  • Loading branch information
@archmoj
archmoj committed Oct 22, 2018
commit 4e8c3ee64ec3bd9db5516b5130cb4469c408cdea
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"gl-contour2d": "^1.1.4",
"gl-error3d": "^1.0.7",
"gl-heatmap2d": "^1.0.4",
"gl-line3d": "git://github.com/gl-vis/gl-line3d.git#dfbd94f4290d30097c9b7c9f36d2a241732124c0",
"gl-line3d": "git://github.com/gl-vis/gl-line3d.git#33b9e850de754cde38d859328ae562125edc90f2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gl-vis/gl-line3d#7

"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.0",
"gl-plot2d": "^1.3.1",
Expand Down
Binary file added test/image/baselines/gl3d_line_rectangle_render.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions test/image/mocks/gl3d_line_rectangle_render.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
"data": [
{
"type": "scatter3d",
"mode": "lines",
"line": {"width": 40},
"x":[2,1,0.9659258262890683,0.8660254037844387,0.7071067811865476,0.5000000000000001,0.25881904510252074,6.123233995736766e-17,-0.25881904510252085,-0.4999999999999998,-0.7071067811865475,-0.8660254037844387,-0.9659258262890682,-1,-0.9659258262890684,-0.8660254037844386,-0.7071067811865477,-0.5000000000000004,-0.25881904510252063,-1.8369701987210297e-16,0.25881904510252113,0.5000000000000001,0.7071067811865474,0.8660254037844384,0.9659258262890683,1],
"y":[0,0,0.25881904510252074,0.49999999999999994,0.7071067811865475,0.8660254037844386,0.9659258262890683,1,0.9659258262890683,0.8660254037844387,0.7071067811865476,0.49999999999999994,0.258819045102521,1.2246467991473532e-16,-0.25881904510252035,-0.5000000000000001,-0.7071067811865475,-0.8660254037844385,-0.9659258262890683,-1,-0.9659258262890682,-0.8660254037844386,-0.7071067811865477,-0.5000000000000004,-0.2588190451025207,0],
"z":[-1,0,0.2617993877991494,0.5235987755982988,0.7853981633974483,1.0471975511965976,1.3089969389957472,1.5707963267948966,1.8325957145940461,2.0943951023931953,2.356194490192345,2.6179938779914944,2.8797932657906435,3.141592653589793,3.4033920413889422,3.6651914291880923,3.9269908169872414,4.1887902047863905,4.4505895925855405,4.71238898038469,4.97418836818384,5.235987755982989,5.497787143782138,5.759586531581287,6.021385919380437,6.283185307179586]
}
],
"layout": {
"width": 400,
"height": 800,
"scene": {
"camera": {
"eye": {
"x": 1.5,
"y": 0.0,
"z": -1.5
},
"center": {
"x": 0.0,
"y": 0.0,
"z": 0.0
},
"up": {
"x": 0.0,
"y": 0.0,
"z": 1.0
}
},
"xaxis": {
"title": "<==X.X==>"
},
"yaxis": {
"title": "<==Y.Y==>"
},
"zaxis": {
"title": "<==Z.Z==>"
}
}
}
}