Skip to content

Finalist - Improve rendering of lines in 3D (against disappearing in certain angles) issue #691 #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 26, 2018
Merged
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"gl-contour2d": "^1.1.4",
"gl-error3d": "^1.0.8",
"gl-heatmap2d": "^1.0.4",
"gl-line3d": "^1.1.3",
"gl-line3d": "^1.1.4",
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.1",
"gl-plot2d": "^1.3.1",
Expand Down
Binary file modified test/image/baselines/gl3d_cube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_projection-traces.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_scatter-color-mono-and-palette.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_scatter3d-connectgaps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/plot_types.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
72 changes: 72 additions & 0 deletions test/image/mocks/gl3d_line_rectangle_render.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
"data": [
{
"x":[-2,-1.867,-1.5,-1,-0.5,-0.134,0,-0.134,-0.5,-1,-1.5,-1.867,-2],
"y":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"z":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"type": "scatter3d", "mode": "lines", "line": {"width": 20, "dash": "dash"}
},
{
"x":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"y":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"z":[-2,-1.867,-1.5,-1,-0.5,-0.134,0,-0.134,-0.5,-1,-1.5,-1.867,-2],
"type": "scatter3d", "mode": "lines", "line": {"width": 20, "dash": "dash"}
},
{
"x":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"y":[-2,-1.867,-1.5,-1,-0.5,-0.134,0,-0.134,-0.5,-1,-1.5,-1.867,-2],
"z":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"type": "scatter3d", "mode": "lines", "line": {"width": 20, "dash": "dash"}
},
{
"x":[0,0.133,0.5,1,1.5,1.866,2,1.866,1.5,1,0.5,0.133,0],
"y":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"z":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"type": "scatter3d", "mode": "lines", "line": {"width": 10}
},
{
"x":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"y":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"z":[0,0.133,0.5,1,1.5,1.866,2,1.866,1.5,1,0.5,0.133,0],
"type": "scatter3d", "mode": "lines", "line": {"width": 10}
},
{
"x":[-2,-1.667,-1.334,-1,-0.667,-0.334,0,0.333,0.666,1,1.333,1.666,2],
"y":[0,0.133,0.5,1,1.5,1.866,2,1.866,1.5,1,0.5,0.133,0],
"z":[-0.001,-0.5,-0.867,-1,-0.867,-0.5,0,0.499,0.866,1,0.866,0.499,0],
"type": "scatter3d", "mode": "lines", "line": {"width": 10}
}
],
"layout": {
"width": 1200,
"height": 900,
"scene": {
"camera": {
"eye": {
"x": -1.0,
"y": -1.0,
"z": -1.0
},
"center": {
"x": 0.0,
"y": 0.0,
"z": 0.0
},
"up": {
"x": 0.0,
"y": 0.0,
"z": 1.0
}
},
"xaxis": {
"title": "<==X.X==>"
},
"yaxis": {
"title": "<==Y.Y==>"
},
"zaxis": {
"title": "<==Z.Z==>"
}
}
}
}