Do not add <base> href to SVG clip paths during toImage #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass it as third argument, to keep setClipUrl compatible with `selection.call(method, ...args)` - needed to pass gd to ErrorBars.plot to clip errorbars
... but I'm not sure that's correct. We might still need that
baseUrl for staticPlot:true graph don't get exported
via Plotly.toImage or Plotly.downloadImage.
... now that we pass 'gd' to Drawing.setClipUrl
... instead of 'staticPlot', which can conflict when
users want to draw a 'static plot' in the browser.
etpinard
commented
Nov 20, 2018
|
Looks good to me 💃 but maybe let's wait for @Braintelligence to confirm it fixed his issue. |
... as it is not part of the user-facing config options.
|
I'm happy now, and your update to @Braintelligence's fiddle #3260 (comment) works for me - so 💃 from my side but perhaps we can wait for @Braintelligence to confirm. |
|
Sorry guys, I am on vacation. I can confirm tomorrow, but if my fiddle doesn't behave like described anymore, it should be alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3260
@plotly/plotly_js to do this "properly" i.e. w/o doing something hacky in
Snapshot.toSVGlikeI made
Drawing.setClipUrlexpectgdas third argument. This means we can stash the<base>href ongd._context(instead of onDrawing) and use it insetClipUrl.