Add (some) IE11 testing on AppVeyor #3285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful! That's a nice start 💃 |
test/jasmine/tests/lib_test.js
Outdated
| vals.push( | ||
| Number.MAX_VALUE, Number.MIN_VALUE, Number.EPSILON, | ||
| -Number.MAX_VALUE, -Number.MIN_VALUE, -Number.EPSILON | ||
| ); |
There was a problem hiding this comment.
Oh dear, IE doesn't support these? We use MAX_VALUE:
plotly.js/src/constants/numerical.js
Line 26 in 077a1d7
There was a problem hiding this comment.
Ah good eye, MAX_VALUE is a thing in IE:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_VALUE
as is MIN_VALUE. Only, EPSILON isn't
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/EPSILON
There was a problem hiding this comment.
fixed in -> 50218de
|
Excellent! 💃 I like the idea of an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #431
Looks like AppVeyor has gotten a lot better in the last three years, adding IE11 tests was relatively easy.
Note that this iteration only tests the
lib_test.jssuite. We should add more IE11 tests eventually, perhaps by adding a specialty suite intest/jasmine/bundle_tests/ie11_test.jsor by adding a@ie11jasmine tag.But as discussed in #431 (comment), adapting all our jasmine tests (especially our pixel-based tests) might be too much of a pain for little benefit.
cc @plotly/plotly_js