Fix mathjax placement in ternary aaxis titles #3513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoinerg or @archmoj could one of you review this thing at some point today? Thank you! |
archmoj
reviewed
Feb 5, 2019
src/lib/svg_text_utils.js
Outdated
| @@ -134,7 +134,7 @@ exports.convertToTspans = function(_context, gd, _callback) { | |||
| else if(svgClass[0] === 'l') { | |||
| newSvg.attr({x: _context.attr('x'), y: dy - (newSvgH / 2)}); | |||
| } | |||
| else if(svgClass[0] === 'a') { | |||
| else if(svgClass[0] === 'a' && svgClass.indexOf('atitle') === -1) { | |||
There was a problem hiding this comment.
Could we use
if(svgClass === 'atitle') {
here?
There was a problem hiding this comment.
Why would that be better?
There was a problem hiding this comment.
I was wondering of an edge case where 'atitle' appears in other position in the text.
Though I was not able find any word containing those letters in order!
Anyway could we use this condition instead to test if atitle only occurs at the start of the string?
else if(svgClass[0] === 'a' && svgClass.indexOf('atitle') !== 0) {
There was a problem hiding this comment.
Ok. Done in -> c7878b3
|
Thanks @etpinard for fixing this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3455 -- cc @plotly/plotly_js
I was really hoping to get rid of this hacky block
plotly.js/src/lib/svg_text_utils.js
Lines 127 to 142 in 84e24aa
entirely, but since our MathJax test coverage is lackluster, I chose the safe road.