Skip to content

Axis category ordering - adds feature #189 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2016
Merged

Axis category ordering - adds feature #189 #419

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94e0133
#189 adding axis attributes to cartesian plots and gl3d plots
monfera Apr 13, 2016
e36d163
#189 category ordering - final, bisecting version
monfera Apr 13, 2016
df9ee94
#189 categorymode defaults
monfera Apr 13, 2016
eb499d4
#189 putting categorymode, categorylist and coercion into use
monfera Apr 13, 2016
c7fb84b
#189 jasmine tests
monfera Apr 13, 2016
02ed858
#189 image test mocks and baseline images
monfera Apr 13, 2016
53f12da
#189 PR feedback
monfera Apr 14, 2016
14908d0
#189 Renaming attributes
monfera Apr 15, 2016
b21ebb2
#189 Renamings in image plot titles and image test filenames
monfera Apr 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#189 categorymode defaults
  • Loading branch information
@monfera
monfera committed Apr 13, 2016
commit df9ee94c412eda079916b68c98a8aa11125bcb24
39 changes: 39 additions & 0 deletions src/plots/cartesian/category_mode_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/**
* Copyright 2012-2016, Plotly, Inc.
* All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

var layoutAttributes = require('./layout_attributes');

module.exports = function handleCategoryModeDefaults(containerIn, containerOut, coerce) {

if(containerIn.type !== 'category') return;

var validCategories = layoutAttributes.categorymode.values;

var properCategoryList = Array.isArray(containerIn.categorylist) && containerIn.categorylist.length > 0;

if(validCategories.indexOf(containerIn.categorymode) === -1 && properCategoryList) {

// when unspecified or invalid, use the default, unless categorylist implies 'array'
coerce('categorymode', 'array'); // promote to 'array'

} else if(containerIn.categorymode === 'array' && !properCategoryList) {

// when mode is 'array' but no list is given, revert to default

containerIn.categorymode = 'trace'; // revert to default
coerce('categorymode');

} else {

// otherwise use the supplied mode, or the default one if unsupplied or invalid
coerce('categorymode');

}
};