Skip to content

image trace type #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 24, 2019
Merged

image trace type #4289

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8429245
image: attributes
antoinerg Oct 21, 2019
e86c95b
image: implementation
antoinerg Oct 21, 2019
e7eeb38
add category 'noSortingByValue' and tag appropriate Cartesian traces
antoinerg Oct 21, 2019
73c0740
image: fix style, update attribute's valType and description
antoinerg Oct 21, 2019
10c9914
image: put imagelayer underneath heatmap
antoinerg Oct 21, 2019
b998a17
image: fix zmin/zmax description, test zmin/zmax with wrong length array
antoinerg Oct 22, 2019
dec9469
image: remove dimensions in zmin attribute definition
antoinerg Oct 22, 2019
15c06fa
image: handle missing pixels in z
antoinerg Oct 22, 2019
2d393dd
image: use maxRowLength to find the width of z
antoinerg Oct 23, 2019
fa04037
image: fix log axis range, add support for categorical axis
antoinerg Oct 22, 2019
0eb6604
image: add editType clearAxisTypes to `x0` and `y0`
antoinerg Oct 23, 2019
e2a9c6e
image: :lock: down that `x0` and `y0` can be restyled to/from category
antoinerg Oct 23, 2019
a98ac44
image: in hovertemplate, rename c to color
antoinerg Oct 23, 2019
fd51e20
image: add (hover)text attributes with test
antoinerg Oct 23, 2019
5d7f9a4
image: :hocho: duplicated logic in event_data, enforce dim of color
antoinerg Oct 23, 2019
e4cac27
image: do not display color information by default
antoinerg Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
image: use maxRowLength to find the width of z
  • Loading branch information
@antoinerg
antoinerg committed Oct 23, 2019
commit 2d393ddab83a5492afaf8a2c2690ddd7da3cb15f
3 changes: 2 additions & 1 deletion src/traces/image/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'use strict';

var Axes = require('../../plots/cartesian/axes');
var maxRowLength = require('../../lib').maxRowLength;

module.exports = function calc(gd, trace) {
var xa = Axes.getFromId(gd, trace.xaxis || 'x');
Expand All @@ -17,7 +18,7 @@ module.exports = function calc(gd, trace) {
var x0 = trace.x0 - trace.dx / 2;
var y0 = trace.y0 - trace.dy / 2;
var h = trace.z.length;
var w = trace.z[0].length;
var w = maxRowLength(trace.z);

trace._extremes[xa._id] = Axes.findExtremes(xa, [x0, x0 + w * trace.dx]);
trace._extremes[ya._id] = Axes.findExtremes(ya, [y0, y0 + h * trace.dy]);
Expand Down