-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Introduces attribute source
to image traces
#5075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1c893e2
Introduces attribute "source" to image traces featuring fast rendering
antoinerg d45496d
Ignores image trace's source attribute that are not data URIs
antoinerg f03c7ae
Adds image_labuda_droplets_source to mock_test.js
antoinerg 2a687f2
Add "z" variable to hovertemplate in image defined by source attr
antoinerg aaf7cbc
Append promise of image loading to the plot api so it can wait for it
antoinerg e693446
In image traces, delete source attribute when it is invalid
antoinerg 130593e
Fixes image_test to reflect that invalid source are deleted
antoinerg 09eb1d0
Improve code style in the plot routine of image traces
antoinerg 9b8a843
Add a workaround to image's onload event not firing when image is cached
antoinerg 2ba0998
Introduces Lib.isIOS() to detect Apple mobile devices
antoinerg a2ea331
Fall back to legacy rendering of image traces for iOS devices
antoinerg 4f807c5
Add missing semicolon
antoinerg 7dd3b68
Fall back to legacy rendering of images traces for IE
antoinerg f2caed8
Loads images into an <img> instead of an <image> for image traces
antoinerg d91e0c1
Reintroduce image traces with source attribute in the `test-image` suite
antoinerg fe1d208
Improves code readability for image traces
antoinerg 2960e55
Removes broken test following changes in how image traces check userA…
antoinerg 3717cbe
Rename _isFrom(Z|Source) to _has(Z|Source)
antoinerg b586a86
Replace Labuda's photography of droplets by one from public domain
antoinerg d73f4c4
Add image_astronaut_source to mock_test.js
antoinerg 18133c9
Update description of attribute `source` in images traces
antoinerg 19ce21d
Introduce colormodel "rgba256" to image traces
antoinerg 74574b6
Update description of attribute colormodel in image traces
antoinerg 8c736f7
Update description of attribute source in image traces
antoinerg 3b75921
Prefer z data over source in image traces and improve code readability
antoinerg 66c58f6
:hocho: unreachable code in image trace defaults routine
antoinerg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.