Skip to content

install image-size in dependencies #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

install image-size in dependencies #5119

merged 1 commit into from
Sep 3, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 3, 2020

The size-image module should have been moved from dev-dependencies to dependencies in #5075.

This caused the streambed tests to fail:
https://app.circleci.com/pipelines/github/plotly/streambed/4623/workflows/a68b7b90-9b44-4ab3-909b-d0fa4ed3bd07/jobs/58431

cc: https://github.com/plotly/streambed/pull/14972

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Sep 3, 2020
@archmoj archmoj merged commit d2ae743 into master Sep 3, 2020
@archmoj archmoj deleted the reinstall-image-size branch September 3, 2020 00:24
@silviubogan
Copy link

Hi!

I did not find the time to read the entire the discussion, but IMHO image-size should be in dev dependencies list because, for example, image-size uses the fs module which is not available in the browsers (in my case through webpack). Maybe it is just my specific case but any help is appreciated.

What can I do if, through plotly.js, I get this error:?

image

Thank you!

@archmoj
Copy link
Contributor Author

archmoj commented Nov 3, 2020

@silviubogan unfortunately we cannot move image-size to dev-dependencies while it is required in traces/image:

plotly.js/src/traces/image/helpers.js

Line 11 in 0d79ea9

var sizeOf = require('image-size');

BTW please feel free to open a new issue concerning your problem or alternatively submit a PR to replace image-size with another module that could return the size of an image of png, jpg, bmp and gif formats.

@silviubogan silviubogan mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @silviubogan