Skip to content

no resize cursor on static sliders #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

no resize cursor on static sliders #6397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
449aa8b
no resize cursor on static sliders
archmoj Dec 14, 2022
4e4023e
log for PR 6397
archmoj Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
no resize cursor on static sliders
  • Loading branch information
@archmoj
archmoj committed Dec 14, 2022
commit 449aa8be2e02c2961d4cd394d3ccab59234fcdcd
3 changes: 2 additions & 1 deletion src/components/sliders/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ var FROM_TL = alignmentConstants.FROM_TL;
var FROM_BR = alignmentConstants.FROM_BR;

module.exports = function draw(gd) {
var staticPlot = gd._context.staticPlot;
var fullLayout = gd._fullLayout;
var sliderData = makeSliderData(fullLayout, gd);

Expand All @@ -27,7 +28,7 @@ module.exports = function draw(gd) {

sliders.enter().append('g')
.classed(constants.containerClassName, true)
.style('cursor', 'ew-resize');
.style('cursor', staticPlot ? null : 'ew-resize');

function clearSlider(sliderOpts) {
if(sliderOpts._commandObserver) {
Expand Down