Skip to content

Property ticklabelindex for custom tick label display #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jul 10, 2024
Merged

Property ticklabelindex for custom tick label display #7036

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
e5725c6
Property `drawminorticklabel` for drawing the label for each minor ti…
my-tien Jun 25, 2024
11fd3f1
Ensure correct spacing between ticklabels and ticks when using drawmi…
my-tien Jun 25, 2024
a3e41af
baseline test mock for drawminorticklabel
my-tien Jun 25, 2024
f7d9abf
Draftlog for PR 7036 (drawminorticklabel)
my-tien Jun 25, 2024
1f52f4e
"noDrawminorticklabel" exception for gl3d plots
my-tien Jun 25, 2024
35a7f51
Fix failing source-syntax check: missing newline in mock
my-tien Jun 27, 2024
0a80d24
Restrict drawminorticklabel to period axes
my-tien Jun 27, 2024
1e7ebc3
Revert "Ensure correct spacing between ticklabels and ticks when usin…
my-tien Jun 27, 2024
0671ebb
Update mock after restricting new property to period axes
my-tien Jun 27, 2024
6fcda1a
baseline image for zzz_drawminorticklabel_period_axes.png
my-tien Jun 27, 2024
21a573c
Refactor periodCompatibleWithTickformat to make behavior clearer.
my-tien Jul 5, 2024
e511fc8
Note about possible future extension of the minor tick label customiz…
my-tien Jul 4, 2024
7585121
Honor ticklabelstep also when using drawminorticklabel
my-tien Jul 5, 2024
e2493a6
drawminorticklabel mock for date_axes_period, date_axes_period2, date…
my-tien Jul 5, 2024
00971f1
Mention in description that drawminorticklabel only applies to period…
my-tien Jul 5, 2024
6f5ba12
Missing trailing newlines for mocks
my-tien Jul 5, 2024
cd7e7c1
Baseline images for new drawminorticklabel mocks
my-tien Jul 5, 2024
ee329a3
Merge remote-tracking branch 'origin-plotly/master' into custom_tick_…
my-tien Jul 5, 2024
0019cb0
Rename drawminorticklabel → ticklabelindex
my-tien Jul 8, 2024
e328c9f
Allow `ticklabelindex` also for non-period date axes and linear axes.
my-tien Jul 8, 2024
a580821
Update `ticklabelindex` description after allowing linear and date axes.
my-tien Jul 8, 2024
16d792c
Add constant ONEMILLI
my-tien Jul 8, 2024
82f1fa0
Fix missing EOF newline in zzz_date_axes_ticklabelindex.json
my-tien Jul 8, 2024
908deec
New and updated baseline images for ticklabelindex mocks
my-tien Jul 8, 2024
884d975
Satisfy eslint rules
my-tien Jul 8, 2024
6fd6bd4
Fix ticklabelindex for reversed axes
my-tien Jul 9, 2024
05d456d
Add `arrayOk` for `ticklabelindex`, add test case to mock
my-tien Jul 9, 2024
d351462
Update baseline image for zzz_ticklabelindex after adding more test c…
my-tien Jul 9, 2024
96a26da
replace Array.isArray with Lib.isArrayOrTypedArray
my-tien Jul 9, 2024
64e14d6
Add to ticklabelindex description how it can be useful for period axes
my-tien Jul 10, 2024
50b1e0f
Mention contributor in draftlog
my-tien Jul 10, 2024
86b43e4
refactor calcTicks
my-tien Jul 10, 2024
0515237
refactor calcTicks
my-tien Jul 10, 2024
b6903e4
comment about possible extra values for ticklabelindex
my-tien Jul 10, 2024
f8974e0
Mention contributor in draftlog for PR 7006
my-tien Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update mock after restricting new property to period axes
  • Loading branch information
@my-tien
my-tien committed Jun 27, 2024
commit 0671ebb2572f8c8cfc4b813473a74b718d6552d0
4 changes: 2 additions & 2 deletions test/image/mocks/zzz_drawminorticklabel_period_axes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
},
"xaxis2": {
"title": {
"text": "xaxis2: Label of minor tick before each major tick is drawn"
"text": "xaxis2: Period before each major tick is labeled"
},
"dtick": "M12",
"minor": {
Expand All @@ -175,7 +175,7 @@
},
"tickformat": "%b %Y",
"drawminorticklabel": -1,
"tickangle": 30,
"tickangle": 90,
"ticklabelmode": "period",
"ticklen": 18,
"ticks": "inside",
Expand Down