Skip to content

add deprecation warning for mapbox traces and mapbox subplot #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 29, 2024
Merged

add deprecation warning for mapbox traces and mapbox subplot #7087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b46461
add deprecation warning for mapbox traces and subplot
archmoj Aug 12, 2024
7013fbb
add draftlog
archmoj Aug 12, 2024
2b51c41
fix trace names
archmoj Aug 13, 2024
0822254
add console.warn when using mapbox subplots
archmoj Aug 13, 2024
6a906bb
use Lib.warn instead of console.log
archmoj Aug 13, 2024
4cbe129
Add link to migration guide to deprecation warning
ndrezn Aug 29, 2024
c11a02a
update plot schema
archmoj Aug 29, 2024
e609834
lint fix
archmoj Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix trace names
  • Loading branch information
@archmoj
archmoj committed Aug 13, 2024
commit 2b51c41d77991c2792233dd3b7ca507c0895d95e
2 changes: 1 addition & 1 deletion src/traces/choroplethmapbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var deprecationWarning = [
'*choroplethmapbox* trace is deprecated!',
'Please consider switching to the *scattermap* trace type and `map` subplots.'
'Please consider switching to the *choroplethmap* trace type and `map` subplots.'
].join(' ');

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion src/traces/densitymapbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var deprecationWarning = [
'*densitymapbox* trace is deprecated!',
'Please consider switching to the *scattermap* trace type and `map` subplots.'
'Please consider switching to the *densitymap* trace type and `map` subplots.'
].join(' ');

module.exports = {
Expand Down
4 changes: 2 additions & 2 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29865,7 +29865,7 @@
"showLegend"
],
"meta": {
"description": "*choroplethmapbox* trace is deprecated! Please consider switching to the *scattermap* trace type and `map` subplots. GeoJSON features to be filled are set in `geojson` The data that describes the choropleth value-to-color mapping is set in `locations` and `z`.",
"description": "*choroplethmapbox* trace is deprecated! Please consider switching to the *choroplethmap* trace type and `map` subplots. GeoJSON features to be filled are set in `geojson` The data that describes the choropleth value-to-color mapping is set in `locations` and `z`.",
"hr_name": "choropleth_mapbox"
},
"type": "choroplethmapbox"
Expand Down Expand Up @@ -37282,7 +37282,7 @@
"showLegend"
],
"meta": {
"description": "*densitymapbox* trace is deprecated! Please consider switching to the *scattermap* trace type and `map` subplots. Draws a bivariate kernel density estimation with a Gaussian kernel from `lon` and `lat` coordinates and optional `z` values using a colorscale.",
"description": "*densitymapbox* trace is deprecated! Please consider switching to the *densitymap* trace type and `map` subplots. Draws a bivariate kernel density estimation with a Gaussian kernel from `lon` and `lat` coordinates and optional `z` values using a colorscale.",
"hr_name": "density_mapbox"
},
"type": "densitymapbox"
Expand Down