Skip to content

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513

wants to merge 4 commits into from

Conversation

Lexachoc
Copy link
Contributor

@Lexachoc Lexachoc commented Aug 7, 2025

Regression since v3.0.0 (#7212)

After introducing title.text, some plots and components edit function breaks. This PR the issue. Also closes #7512 .

Affected plots

  1. Ternary plot: aaxis.title.text, baxis.title.text, and caxis.title.text
  2. Polar plot: radialaxis.title.text

Affected components

  1. Colorbar: title.text
  2. Rangeslider: xaxis.title.text

@Lexachoc
Copy link
Contributor Author

Lexachoc commented Aug 7, 2025

No ideas why the https://github.com/plotly/plotly.js/blob/bddbb149ba2ffe5baf310867ef6cf3c27af65d6a/test/jasmine/tests/transition_test.js fails.

plotly.js/test/jasmine/tests/transition_test.js

Lines 646 to 652 in bddbb14

.then(function() {
data[0].marker.color = 'black';
layout.xaxis.range = [-1, 1];
return Plotly.react(gd, data, layout);
})
.then(delay(50))
.then(function() {

I found that the increased delay time in #7343 is not long enough (I have no idea why it doesn't work in my case, as I haven't changed the transition logic I think).

After increasing the delay time from 50 to 100, it works when I run npm run test-jasmine -- transition locally.

However, this is unreliable in the GitHub workflow! The delay may need to be increased.

@gvwilson gvwilson removed the request for review from camdecoster August 11, 2025 17:20
@gvwilson gvwilson added community community contribution P1 needed for current cycle fix fixes something broken labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl Awaiting requested review from emilykl

At least 1 approving review is required to merge this pull request.

Assignees

@emilykl emilykl

Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

title.text cannot be edited for multiple plots/components (regression since v3.0.0)
3 participants
@Lexachoc @gvwilson @emilykl