Fix broken styling of map attributions #7526
Open
+67
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we discussed, with this change, I think that this section can be removed: plotly.js/tasks/util/bundle_wrapper.mjs Lines 49 to 57 in 04441f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/plotly/plotly-studio/issues/1175
Map attributions were styled incorrectly for plots using MapLibre (
scattermap,densitymap,scattermaptraces).This was because a MapLibre stylesheet was missing due to being incorrectly handled in the bundling process.
The bug was introduced by the migration to esbuild (#6909) and present as of Plotly.js 3.0.0.
This PR fixes that issue by using a different tool to inline the missing CSS directly into the JS bundle.
Before fix:
After fix:
This commit demonstrates the resulting difference in the
dist/plotly.jsfile (not included in this PR since we only updatedist/during the release process).As an aside, this was not caught by the image tests because the
Plotly.toImage()function for MapLibre plots callsmap.getCanvas()which does not include the attribution, so Plotly.js manually adds the attribution to the generated image.