Added promise returns to Plotly.___ #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1640,7 +1650,7 @@ Plotly.restyle = function restyle(gd, astr, val, traces) { | |||
| } | |||
| else { | |||
| console.log('restyle fail',astr,val,traces); | |||
| return; | |||
| return new Promise.reject(); | |||
|
Nice. Let's get a test case in |
|
|
||
| Plotly.addTraces(gd, [{'name': 'c'}, {'name': 'd'}]); | ||
| expect(gd).toEqual(expected); | ||
| expect(gd.data).toEqual(expectedData); |
There was a problem hiding this comment.
FYI @bpostlethwaite no need to check the whole gd, just checking its data is more than enough here.
2 tasks
|
💃 |
mdtusz
added a commit
that referenced
this pull request
Dec 7, 2015
Added promise returns to Plotly.___
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added promise returns for exposed methods in
plot_api.js, and they will all be sent along with the gd.#76
Tests on
npm run test-imageare not passing on my machine, but let's see if they pass on circle!