Mapbox access token catches #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, function() { | ||
| // clear the promise queue if one of them got rejected | ||
| Lib.log('Clearing previous rejected promises from queue.'); | ||
| gd._promises = []; |
There was a problem hiding this comment.
I was under the impression that the 2nd argument to Promise.all().then(, ) was simply a callback and did not eat any subsequent Plotly.plot().catch() handlers. I was wrong.
|
Error caught in filewell! Thanks a lot man 👍 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #729 and on display here: http://codepen.io/lpan/pen/kXJzbY?editors=0011 discovered by @lpan .