Skip to content

Horizontal legend traces wrap to new lines #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 2, 2016
Merged

Horizontal legend traces wrap to new lines #786

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bb60510
Might fix #769 - added check for pushing past plot margin and startin…
psalmody Jul 22, 2016
5f38595
linted
psalmody Jul 22, 2016
5b5a102
code in original order
psalmody Jul 22, 2016
d0934f3
changes based on @n-riesco comments
psalmody Jul 25, 2016
e7a286f
need both margins for proper wrapping
psalmody Jul 25, 2016
91d384b
put horizontal legend traces in columns
psalmody Jul 26, 2016
7ef2dff
Merge pull request #2 from psalmody/h-legend-cols
psalmody Jul 26, 2016
919d8c8
Merge pull request #1 from psalmody/h-legend-wrap
psalmody Jul 27, 2016
8d6299f
lint
psalmody Jul 27, 2016
3a2cf7b
image mock and test
psalmody Jul 28, 2016
e1225fa
add image test
psalmody Jul 30, 2016
c31eb68
test rewrite per request
psalmody Aug 2, 2016
75bb57f
remove duplicative test, add relayout test
psalmody Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
need both margins for proper wrapping
  • Loading branch information
@psalmody
psalmody committed Jul 25, 2016
commit e7a286fc4abdbd04da39ee21e5b4e6977a1719db
2 changes: 1 addition & 1 deletion src/components/legend/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ function computeLegendDimensions(gd, groups, traces) {
traceWidth = 40 + legendItem.width,
traceGap = opts.tracegroupgap || 5;

if((borderwidth + offsetX + traceGap + traceWidth) > fullLayout.width - fullLayout.margin.r) {
if((borderwidth + offsetX + traceGap + traceWidth) > (fullLayout.width - (fullLayout.margin.r + fullLayout.margin.l))) {
offsetX = 0;
rowHeight = rowHeight + maxTraceHeight;
opts.height = opts.height + maxTraceHeight;
Expand Down