Skip to content

HTML-encode attributes in <tspan>s and <a>s #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2016
Merged

HTML-encode attributes in <tspan>s and <a>s #791

merged 3 commits into from
Jul 29, 2016

Conversation

scjody
Copy link
Contributor

@scjody scjody commented Jul 29, 2016

I don't believe this is necessary for security, but it makes our code more obviously secure.

scjody added 3 commits July 28, 2016 20:44
@scjody
HTML encode attributes in <tspan>s and <a>s
9e2f251 
I don't believe this is necessary for security, but it makes our code
more obviously secure.
@scjody
Add tests of <tspan> generation
4e2761c
@scjody
Add test that relative links work
763485c
@mdtusz
Copy link
Contributor

mdtusz commented Jul 29, 2016

💃

@etpinard
Copy link
Contributor

Nicely done 💃

@etpinard etpinard added this to the v1.16.0 milestone Jul 29, 2016
@scjody scjody merged commit 8fc47ef into master Jul 29, 2016
@scjody scjody deleted the html-encode-attributes branch July 29, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@scjody @mdtusz @etpinard