Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lib.isPlainObject
fails in ourimagetest
docker image test container at the moment.More specifically,
is
false
for plain objects inimagetest
. This behaviour is due to how the async utilitylash
applies functions to objects. Making a fixlash
and/or theimagetest
would have been arduous, so I decided to patchLib.isPlainObject
instead.The patch in c09cbb3 makes
Lib.isPlainObject
only check forin
nw.js
environments. This lead toto return
true
. I'd argue that this is fine inimagetest
where request bodies are JSON stringified and JSON parsed before plotting - note thatJSON.parse(JSON.stringify(new A())
returns{}
.Commit e1f6818 enforces
Lib.isPlainObject
is the source files.