Make plot_css_test.js asynchronous #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #764
cc: @etpinard @nielsenb-jf
The child window test in
plot_css_test.jsis asynchronous but was not implemented as such. As a result, things didn't get cleaned up and d3 transitions after this test gave a crypticTypeError: d3_window(...) is undefinederror. This PR makes all three tests asynchronous.For reference, strategies used to debug:
files: [...]explicitly + alphabetically inkarma.ciconf.jsand removed them via bisection until the tests that interacted problematically were isolated