Fix validation logic for arrays attributes and array containers #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by default, input info array must have same length as the declared version, now with 'freeLength' this doesn't have to be. - set freeLength to true for the updatem menus 'args' attribute
- so that we can keep track of 'skipped-over' containers e.g. 'buttons' items are skipped over when their content is invalid
- make sure that invalid and skipped-over containers lead to validation errors. - make sure to track the input index to match schema/value with the correct input container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few problems with
Plotly.validateandisLinkedToArrayattributes (which are becoming more and more numerous). Here are a few fixes.