Faster relink private keys #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as before 37e291b - this can lead to significant speed up when large data arrays are present
|
@etpinard looks perfect, speed is back to around 100ms in the benchmark of 1m+1k points addition test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
relinkPrivateKeysstep was refactor in 37e291b, to accommodate transform operation they may change the side of array containers.In doing so, it made the
Plots.supplyDefaultsstep dive into all arrays present in"data"/"layout"- not just array container (e.g. annotations, images, etc as originally intended. My mistake.