Skip to content

No auto load graph reference #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

No auto load graph reference #643

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9011489
Try getting the error message in response_handler
alexandresobolevski Dec 21, 2016
bd801dd
Did not mean to commit this
alexandresobolevski Dec 21, 2016
e706aba
Always raise PlotlyRequestError
alexandresobolevski Dec 22, 2016
20d8b3b
Change expected exception
alexandresobolevski Dec 22, 2016
c8092f8
Factor out `get_config` and `get_credentials`.
theengineear Dec 22, 2016
2615218
Generalize our `PlotlyRequestError`.
theengineear Dec 27, 2016
3a247c0
Create organized api modules :tada:!
theengineear Dec 27, 2016
3ad476b
Use the new api definitions in all api calls.
theengineear Dec 27, 2016
fd38bda
Use `api.v2.plot_schema` to get GRAPH_REFERENCE.
theengineear Dec 27, 2016
62d90d0
:wrench: Allow `proxy_*` in `sign_in`.
theengineear Dec 27, 2016
4cd52bd
Update default schema.
theengineear Dec 28, 2016
5886831
Use requests.compat.json instead of plain json.
theengineear Dec 29, 2016
f53fb41
Don’t auto-download graph reference on import.
theengineear Dec 30, 2016
6511aad
Add file to auto-generate graph objects.
theengineear Dec 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always raise PlotlyRequestError
  • Loading branch information
@alexandresobolevski
alexandresobolevski committed Dec 22, 2016
commit e706aba2354e424938f7809953005cf1cec2f3dd
8 changes: 5 additions & 3 deletions plotly/plotly/plotly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,9 +1318,11 @@ def response_handler(cls, response):
errors = parsed_response.get('errors')
message = errors[-1]['message']
except:
raise requests_exception

raise exceptions.PlotlyError(message)
# otherwise raise a generic error
raise exceptions.PlotlyRequestError(requests_exception)
else:
requests_exception.message = message
raise exceptions.PlotlyRequestError(requests_exception)

if ('content-type' in response.headers and
'json' in response.headers['content-type'] and
Expand Down