Skip to content

Add docs for Jupyter NB test suite #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2017
Merged

Add docs for Jupyter NB test suite #653

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
714d34d
add docs about jupyter nb test suite
etpinard Jan 6, 2017
59838ee
add test checking that js deps are present
etpinard Jan 6, 2017
57a4005
typos
etpinard Jan 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test checking that js deps are present 
- which should make debugging somewhat less painful
  • Loading branch information
@etpinard
etpinard committed Jan 6, 2017
commit 59838eefe5441d578cb42e68fcbc3dba457940c8
7 changes: 7 additions & 0 deletions plotly/tests/test_optional/test_jupyter/test_jupyter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,17 @@
import subprocess

PATH_ROOT = path.dirname(__file__)
PATH_NODE_MODULES = path.join(PATH_ROOT, 'node_modules')
PATH_FIXTURES = path.join(PATH_ROOT, 'fixtures')
PATH_JS_TESTS = path.join(PATH_ROOT, 'js_tests')


class PlotlyJupyterTestDeps(TestCase):

def test_node_modules(self):
self.assertTrue(path.isdir(PATH_NODE_MODULES))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theengineear this test will fail when someone forgets to npm install before running these tests. It should make debugging a little easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice! yah, that's a simple first-pass catch for sure.



class Common(TestCase):
__test__ = False
name = None
Expand Down