Skip to content

FF requires numpy #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2017
Merged

FF requires numpy #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9138516
Fail if user tries to import FF without `numpy`.
theengineear Jan 18, 2017
7e3b358
Move all FF tests into `test_optional`.
theengineear Jan 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ which depend on `try-except` blocks containing network requests should be
revisited.
- `plotly.py:sign_in` now validates to the plotly server specified in your
config. If it cannot make a successful request, it raises a `PlotlyError`.
- `plotly.figure_factory` will raise an `ImportError` if `numpy` is not
installed.

### Deprecated
- `plotly.tools.FigureFactory`. Use `plotly.figure_factory.*`.
Expand Down
6 changes: 5 additions & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,9 @@ test:
- sudo chmod -R 444 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"

# test that giving back write permissions works again
# this also has to pass the test suite that follows
- sudo chmod -R 777 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"

# test that figure_factory cannot be imported with only core requirements.
# since optional requirements is part of the test suite, we don't need to
# worry about testing that it *can* be imported in this case.
- $(! python -c "import plotly.figure_factory")
3 changes: 3 additions & 0 deletions plotly/figure_factory/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from __future__ import absolute_import

# Require that numpy exists for figure_factory
import numpy

from plotly.figure_factory._2d_density import create_2d_density
from plotly.figure_factory._annotated_heatmap import create_annotated_heatmap
from plotly.figure_factory._candlestick import create_candlestick
Expand Down
Empty file added plotly/tests/test_optional/test_tools/__init__.py
View file
Open in desktop
Empty file.
0 ...st_core/test_tools/test_figure_factory.py → ...ptional/test_tools/test_figure_factory.py
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def readme():
'plotly/api/v2',
'plotly/plotly',
'plotly/plotly/chunked_requests',
'plotly/figure_factory',
'plotly/graph_objs',
'plotly/grid_objs',
'plotly/widgets',
Expand Down