Skip to content

isosurface doc #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2019
Merged

isosurface doc #114

merged 2 commits into from
Sep 4, 2019

Conversation

emmanuelle
Copy link
Contributor

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

@emmanuelle
Copy link
Contributor Author

Addresses plotly/documentation#1491

@nicolaskruchten
Copy link
Contributor

Small process note: if you included the text closes https://github.com/plotly/documentation/issues/1491 in your PR description, then that issue will be automatically closed when the PR is merged.

@emmanuelle
Copy link
Contributor Author

oh great thanks

@nicolaskruchten
Copy link
Contributor

💃

@emmanuelle
Copy link
Contributor Author

merging, thanks

@emmanuelle emmanuelle merged commit 4c5808b into master Sep 4, 2019
@emmanuelle
Copy link
Contributor Author

closes plotly/documentation#1491

@emmanuelle emmanuelle deleted the isosurface branch September 4, 2019 17:27
@emmanuelle emmanuelle mentioned this pull request Sep 4, 2019
Closed
@nicolaskruchten
Copy link
Contributor

Ah the "closes" thing needs to be in the description at the very top, for the automation to work: https://help.github.com/en/articles/closing-issues-using-keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuelle @nicolaskruchten