Skip to content

3d volume notebook #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2019
Merged

3d volume notebook #115

merged 3 commits into from
Sep 9, 2019

Conversation

emmanuelle
Copy link
Contributor

@emmanuelle emmanuelle commented Sep 5, 2019 •
edited
Loading

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

Closes plotly/documentation#1492

This is a new notebook.

@emmanuelle
Copy link
Contributor Author

I still have to generate the thumbnail, but I'm pushing first the tutorial so that you can comment

@emmanuelle
Copy link
Contributor Author

The thumbnail is online https://plotly-tutorials.s3-us-west-1.amazonaws.com/plotly-documentation/thumbnail/3d-volume-plots.jpg

nicolaskruchten
nicolaskruchten reviewed Sep 9, 2019
View reviewed changes
python/3d-volume.md Outdated
language: python
layout: user-guide
name: 3D Volume Plots
order: 12.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a valid number :)

@nicolaskruchten
Copy link
Contributor

Hmm so my laptop is really struggling to render these... are these plots particularly complex or...?

@nicolaskruchten
Copy link
Contributor

yeah my Chrome tab crashed trying to render :(

@emmanuelle
Copy link
Contributor Author

Yes these plots are quite resource-intensive to render... which surprised me since the arrays are not that big. I can try to decrease a bit the size of arrays but it'd interesting to see if @archmoj thinks this sluggishness is normal or not...

@emmanuelle
Copy link
Contributor Author

I reduced the grid size it should behave better now.

@nicolaskruchten
Copy link
Contributor

Works for me! 💃

@emmanuelle emmanuelle merged commit 9d3c68c into master Sep 9, 2019
@emmanuelle emmanuelle deleted the volume branch September 9, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten nicolaskruchten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python volume trace docs
2 participants
@emmanuelle @nicolaskruchten