Skip to content

Order refactor #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 13, 2019
Merged

Order refactor #168

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0b41a25
removing duplicate comparing webgl vs svg post
Nov 4, 2019
d7f5885
refactor order in file_settings
Nov 4, 2019
dedfee4
refactor order in basic charts
Nov 4, 2019
2479f33
refactor order in statisctical charts
Nov 4, 2019
b839d39
refactor order in scientific charts
Nov 4, 2019
9f50595
refactor order in financial charts
Nov 4, 2019
6d7b447
refactor order in maps charts
Nov 4, 2019
7d2891a
refactor order in 3d charts
Nov 4, 2019
6d6a71c
refactor order in subplots charts
Nov 4, 2019
4147d72
fixup to order in scientific charts
Nov 4, 2019
823e005
fixup to ordering in base
Nov 4, 2019
6eb11eb
creating script to check order and enforce it
Nov 5, 2019
d2f05ad
fixups to order
Nov 5, 2019
dbd1860
fixup to scripts
Nov 5, 2019
d4d61f9
incrementing order of posts after 5 by 1 to account for index post
Nov 6, 2019
0a623f0
updating check-order so that no post can have order 5 since that is t…
Nov 6, 2019
8e5d02d
merging master
Nov 11, 2019
128fe00
moving trendlines post to end of index to ensure sequential order
Nov 11, 2019
a21e8d5
refactoring check order script to check all display_as categories at …
Nov 11, 2019
fa6d00d
fixing up ci script to catch duplicate orders
Nov 11, 2019
93f0cb9
concat check-order and enforce-order using command line argument for …
Nov 11, 2019
26ba175
dropping check-order.py
Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactoring check order script to check all display_as categories at … 
…once
  • Loading branch information
Joseph Damiba committed Nov 11, 2019
commit a21e8d5518d8551aa4c9755dd1e62987473b5efe
60 changes: 28 additions & 32 deletions check-order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,47 +2,43 @@
from pathlib import Path, PosixPath
import sys

try:
category = str(sys.argv[2])
except:
raise Exception("You need to specify a display_as category!")

categories = ["file_settings", "basic", "statistical", "scientific", "maps", "3d_charts", "multiple_axes"]
try:
path = str(sys.argv[1])
except:
raise Exception("You need to specify a path!")

# will contain all posts with display_as: file_settings
postFamily = []

#get all posts with frontmatter in md format
for md_path in Path(path).glob("**/*.md"):
post = frontmatter.load(str(md_path))
if len(post.metadata.keys()) > 0:
if "display_as" in post.metadata['jupyter']['plotly']:
if post.metadata['jupyter']['plotly']['display_as'] == category:
postFamily.append({'path':str(md_path), 'order' : post.metadata['jupyter']['plotly']['order']})

sortedPostFamily = sorted(postFamily, key = lambda i: i['order'])
for category in categories:
postFamily = []
#get all posts with frontmatter in md format
for md_path in Path(path).glob("**/*.md"):
post = frontmatter.load(str(md_path))
if len(post.metadata.keys()) > 0:
if "display_as" in post.metadata['jupyter']['plotly']:
if post.metadata['jupyter']['plotly']['display_as'] == category:
postFamily.append({'path':str(md_path), 'order' : post.metadata['jupyter']['plotly']['order']})

sortedPostFamily = sorted(postFamily, key = lambda i: i['order'])

order = []
order = []

for post in sortedPostFamily:
if post['order'] == 5:
raise Exception("Order Check Failed! Post {} cannot have order 5!".format(post['path']))
order.append(post['order'])
for post in sortedPostFamily:
if post['order'] == 5:
raise Exception("Order Check Failed! Post {} cannot have order 5!".format(post['path']))
order.append(post['order'])

if order[0] != 1:
raise Exception("Order Check Failed! First post does not have order 1!")
print(order)

def checkConsecutive(l):
return sorted(l) == list(range(min(l), max(l)+1))
if order[0] != 1:
raise Exception("Order Check Failed! First post does not have order 1!")

print(order)
def checkConsecutive(l):
return sorted(l) == list(range(min(l), max(l)+1))

try:
checkConsecutive(order)
except:
raise Exception("Order Check Failed! Orders are not consecutive integers!!")
try:
checkConsecutive(order)
except:
raise Exception("Order Check Failed! Orders are not consecutive integers!!")

print("Order Checks Passed!")
print("Order Checks Passed!")
order = []