Skip to content

document new methods add_shape add_annotation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Conversation

emmanuelle
Copy link
Contributor

I did not replace all update_layout(annotations=[...]) by add_annotation because I feel like sometimes the update_layout syntax is nice for adding a bunch of objects (and it always works when you don't know that the add_* methods exist) but I'm open to changing all occurrences.

@nicolaskruchten
Copy link
Contributor

Works for me! Can we add a similar set of doc updates for layout.images please? they just got the same treatment :)

@nicolaskruchten nicolaskruchten changed the base branch from master to v4.3-docs November 11, 2019 13:59
@nicolaskruchten nicolaskruchten changed the base branch from v4.3-docs to master November 11, 2019 14:45
@nicolaskruchten
Copy link
Contributor

(changing the base back to master as this stuff is already in 4.2)

@emmanuelle
Copy link
Contributor Author

Works for me! Can we add a similar set of doc updates for layout.images please? they just got the same treatment :)

This is done in #163

@nicolaskruchten
Copy link
Contributor

OK great, so let's merge this! 💃

@emmanuelle emmanuelle merged commit e5bafb7 into master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants