Skip to content

[Fix] Fix typo (G.node -> G.nodes) #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2019
Merged

[Fix] Fix typo (G.node -> G.nodes) #176

merged 1 commit into from
Nov 8, 2019

Conversation

rky0930
Copy link
Contributor

@rky0930 rky0930 commented Nov 7, 2019 •
edited
Loading

Fixing typo in Create Edges example code.
(G.node -> G.nodes)

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

@rky0930
[Fix] Fix typo (G.node -> G.nodes)
5197cc0 
Fixing typo in Create Edges example code.  
(G.node -> G.nodes)
@nicolaskruchten
Copy link
Contributor

Thanks! I’m puzzled about why the build passes before this PR... ?

@rky0930
Copy link
Contributor Author

rky0930 commented Nov 7, 2019

I'm not sure.
Maybe because the code snippets in docs is not executed during build process.. ?

@nicolaskruchten
Copy link
Contributor

They definitely are... maybe it doesn’t enter that loop?

@nicolaskruchten
Copy link
Contributor

well, both G.node and G.nodes work with my version of networkx but maybe they just updated or something.

@nicolaskruchten
Copy link
Contributor

Thanks for the PR!

@nicolaskruchten nicolaskruchten merged commit 0aea605 into plotly:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rky0930 @nicolaskruchten