Skip to content

splom notebook #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2019
Merged

splom notebook #29

merged 2 commits into from
Jun 28, 2019

Conversation

emmanuelle
Copy link
Contributor

Doc upgrade checklist:

  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • v4upgrade: true metadata added
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

nicolaskruchten
nicolaskruchten reviewed Jun 27, 2019
View reviewed changes
nicolaskruchten
nicolaskruchten reviewed Jun 27, 2019
View reviewed changes
@nicolaskruchten
Copy link
Contributor

looks good modulo comments ...

@emmanuelle emmanuelle merged commit 47c561c into master Jun 28, 2019
@emmanuelle emmanuelle deleted the splom branch June 28, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten nicolaskruchten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuelle @nicolaskruchten