Skip to content

Fundamentals / Figure Data Structure Page #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

kvdesai
Copy link
Contributor

@kvdesai kvdesai commented Aug 18, 2021

No description provided.

@kvdesai kvdesai requested a review from HammadTheOne August 18, 2021 18:25
Fixed the order tag in the front matter
language: r
layout: base
name: The Figure Data Structure
order: 24
Copy link
Collaborator

@HammadTheOne HammadTheOne Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Python page, this is the first tile shown in the Fundamentals section, which makes sense since it has the figure structure and overview.

We will want to preserve that order for this one as well (and for other sections where it makes sense to do so), meaning we set this to order: 1 and move all subsequent tiles in this section down one by setting their order tag as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was thinking about it. It seems that with a separate PR for each page, the order tag will become difficult to handle until after all the pages in the section are merged.
Can I suggest that we take care of reordering once all the pages in a given section are merged?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine. Let's just make sure we're keeping track of them, so we know when a section is complete and ready to re-order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly, will do. Thanks!

Copy link
Collaborator

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-wise this looks great. The main change we want to make is setting the correct order for the tiles.

Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
@HammadTheOne HammadTheOne self-requested a review August 19, 2021 16:04
Copy link
Collaborator

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@kvdesai kvdesai merged commit 267079c into master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants