-
Notifications
You must be signed in to change notification settings - Fork 120
Added functionality for callbacks #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
h4ck4l1
commented
Apr 25, 2025
- Added functionality of Click event callback
- Added wasm-yew-minimal-callback example in example docs
@andrei-ng please notify any changes, I am unsure when I will respond next week but I will make sure changes take place atmost in next weeks weekend.
Best Regards |
Thank you for the PR! I will review it during the week. |
Sorry, I have been a bit busy & traveling. Will review it this coming week. |
No worries
No worries. I have been lurking between wasm, dioxus and this repo and found something more breaking I've raised this in #4071 in yew this might not be a problem but in frameworks like dioxus SPA the scripts loading takes a bit time and plotly actually takes more time that other frameworks, so when i am using other 3rd party libraries and functions using wasm_bindgen they are giving me an unreachable error. that why i am currently having to inject scripts manually before the calling of new_plot i don't think this will effect yew but for dioxus it will imo, if one uses more that 2 or 3 scripts. please check the issue if you have the time. |
6c5e75d
to
69c1363
Compare
c2b8f92
to
0c92ca0
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
5df0dc7
to
d26ac48
Compare
- update changelog Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
d26ac48
to
fd684ae
Compare
Yes, I agree with the choice, better to have them separate.
Looks great. Did some minor tweaking to make the bar chart /histogram wider.
If you have the time and are willing to do so... that would be awesome. I plan to make use of them in one of my projects as well. |
Interesting, I will check the issue |