Disable updates #125
Disable updates #125
Conversation
plotlyupdate.m relies on this file to determine the remote version
README*.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| \* = `plotlyupdate.m` is currently disabled. Please download the latest version | |||
There was a problem hiding this comment.
It looks like the filename changed as well?
There was a problem hiding this comment.
Maybe instead of starting with this out of the bat, we can include a Install section in this readme and mention that plotlyupdate is disabled parenthetically? Then we can also link to our getting started at plot.ly/matlab/getting-started
There was a problem hiding this comment.
Yeah - that's intentional so that old versions of the wrapper 404 on update. It's really the only way to shutoff the update. We could leave it as is and just let the old wrappers fail to update when they hit the error described in #124, but this way is more intentional/cleaner.
There was a problem hiding this comment.
Ah I see. Will README*.md still show up as the readme in the github repo? Or can we rename it to something else that GitHub will recognize?
There was a problem hiding this comment.
It will show up as README*.md -- we could def rename it to something else though!
There was a problem hiding this comment.
Hm - it looks like it doesn't show up as default on the repo home page for me:
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, sorry I see what you're saying now. Right. I'll investigate!
There was a problem hiding this comment.
I'll add a note on the matlab getting started doc page mentioning that plotlyupdate is temporarily disabled as well
| fprintf('***********************************************\n\n'); | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I forgot about this function. So epic!
Just curious, what else is needed to fix this?
There was a problem hiding this comment.
Basically we now need to handle updating the Matlab-api and Matlab-online versions of the wrapper. So we need to check if the user downloaded the latest version (with the name change) and handle updating that one appropriately. I think going forward we should modify the update script to only update the version of the wrapper located in the MATLAB toolbox (put there after running plotlysetup).
|
Should we also bump the version? |
|
Yeah, +1 for a version bump. |
|
lgtm 💃 |
|
💃 |
@chriddyp / @cldougl
plotlyupdate.mis currently broken as a result of the MATLAB-api ---> MATLAB-Online repo name change. The fix is non-trivial and I would like to add more testing to this function in general. This PR disables the automatic updates for the time being. When a user attempts to update, it will now fail with the following error messages. Thoughts?Error message (version >= 2.2.7):
Error message (version < 2.2.7):