Skip to content

update to the issue 207- #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

update to the issue 207- #288

merged 2 commits into from
Aug 5, 2021

Conversation

nouman-tariq
Copy link
Contributor

updated the attribute check method, and specified the case more, so that it may not cause interference with any other type of graph

updated the attribute check method, and specified the case more, so that it may not cause interference with any other type of graph
@nouman-tariq nouman-tariq changed the title update- update to the issue 207- Aug 4, 2021
@VolKa79
Copy link

VolKa79 commented Aug 4, 2021

Didnt clearly understood about "delete untitled.htlm'.
Its mean every times ones run this he had to delete this previously created resulting plot?

@nouman-tariq
Copy link
Contributor Author

nouman-tariq commented Aug 4, 2021

@VolKa79 no that was the commit mistake-
I had that file additional in the folder, which i did not notice during PR.

it has nothing to do with the issue code

this commit perform two modifications in the last merged issue code-

  1. ischar(temp_plots.FaceAlpha) can throw an error if FaceAlpha property is not present, so I have updated it to isprop() which will not throw any error in case if the property is not present.

  2. second addition, specify the case, only which was originally intended to solve, so that by any chance no other case falls under this scenerio, other than the expected (see issue 207, plotmatrix(X))

@nouman-tariq
Copy link
Contributor Author

@xarico10 please review it sooner!

@xarico10 xarico10 merged commit ff94215 into master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants