Skip to content

fix issue 241 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2021
Merged

fix issue 241 #297

merged 5 commits into from
Aug 5, 2021

Conversation

gilbertogalvis
Copy link
Contributor

No description provided.

@jackparmer
Copy link
Contributor

#241

@jackparmer jackparmer requested review from xarico10 and VolKa79 August 5, 2021 18:22
@xarico10
Copy link
Contributor

xarico10 commented Aug 5, 2021

Getting an error:

theta = [0.1 1.1 5.4 3.4 2.3 4.5 3.2 3.4 5.6 2.3 2.1 3.5 0.6 6.1];
polarhistogram(theta,6)

fig2plotly(gcf, 'offline', false);

Prints:

Unrecognized field name "xaxis1".
We had trouble parsing the histogram object.
This trace might not render properly.

Unrecognized field name "xaxis1".


Error in updateData (line 92)
eval(['xaxis = obj.layout.xaxis' num2str(xsource)
';']);

Error in plotlyfig/update (line 631)
                updateData(obj,n);

Error in plotlyfig (line 216)
                obj.update;

Error in fig2plotly (line 44)
p = plotlyfig(varargin{:});

Error in untitled (line 6)
fig2plotly(gcf, 'offline', false);

@VolKa79
Copy link

VolKa79 commented Aug 5, 2021

Getting the same error as @xarico10 ....

Unrecognized field name "xaxis1".
We had trouble parsing the histogram object.
This trace might not render properly.

Unrecognized field name "xaxis1".

Error in updateData (line 92)
eval(['xaxis = obj.layout.xaxis' num2str(xsource)
';']);

@gilbertogalvis
Copy link
Contributor Author

@VolKa79 @xarico10 please make sure that you are doing pull from the master branch before test this PR. On that line I added a

try ... end
to ensure that error dont occurs.

@xarico10
Copy link
Contributor

xarico10 commented Aug 5, 2021

We're not supposed to pull from the master branch because your changes aren't not supposed to be merged yet. We're supposed to pull from your branch regarding the issue (issue241_fixing in this case). However, I'll re-check

@gilbertogalvis
Copy link
Contributor Author

We're not supposed to pull from the master branch because your changes aren't not supposed to be merged yet. We're supposed to pull from your branch regarding the issue (issue241_fixing in this case). However, I'll re-check

Screen Shot 2021-08-05 at 5 38 51 PM

Please follow this lines and then test it

Copy link
Contributor

@xarico10 xarico10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a catch after every try command.
Line 95 (updateData file)

@gilbertogalvis
Copy link
Contributor Author

Please add a catch after every try command.
Line 95 (updateData file)

ok

@gilbertogalvis gilbertogalvis requested a review from xarico10 August 5, 2021 22:01
@gilbertogalvis
Copy link
Contributor Author

Please add a catch after every try command.
Line 95 (updateData file)

done! Please review it again

@xarico10
Copy link
Contributor

xarico10 commented Aug 5, 2021

Working now. Next step is to make ticks match! For MATLAB the ticks are 0,1,2,3,4 (every unit), however, ticks are being plotted every 0.5 units:
Captura de Pantalla 2021-08-05 a la(s) 5 17 17 p  m
Captura de Pantalla 2021-08-05 a la(s) 5 17 35 p  m

@gilbertogalvis gilbertogalvis merged commit de80bcd into master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants