Skip to content

Create addtheme.m #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2021
Merged

Create addtheme.m #329

merged 6 commits into from
Aug 10, 2021

Conversation

jackparmer
Copy link
Contributor

No description provided.

@jackparmer
Copy link
Contributor Author

jackparmer commented Aug 9, 2021 •
edited
Loading

Brings pre-defined themes from Plotly Python library and adds addtheme function.

Usage:

x = randn(10000,1);
h = histogram(x)
f = fig2plotly(gcf, 'open', false)

image

addtheme(f, 'plotly_dark')
plotlyoffline(f)

image

addtheme(f, 'ggplot2')
plotlyoffline(f)

image

addtheme(f, 'bugs bunny')
plotlyoffline(f)

image

@jackparmer
Copy link
Contributor Author

Python version: https://plotly.com/python/templates/

xarico10
xarico10 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@xarico10 xarico10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good, however, I have some recommendations for addtheme.m:

  1. The 80 column limit is being violated in line 10
  2. I think that in line 28 and 33 I don't think that brackets are needed. There's a warning on those lines regarding this issue:

Captura de Pantalla 2021-08-09 a la(s) 1 43 03 p  m

@jackparmer
Copy link
Contributor Author

@xarico10 Great feedback. Addressed in 2004548
Please see what you think!

@jackparmer jackparmer merged commit 0c42866 into master Aug 10, 2021
@jackparmer jackparmer mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xarico10 xarico10 xarico10 approved these changes

@gilbertogalvis gilbertogalvis Awaiting requested review from gilbertogalvis

@harshpurwar harshpurwar Awaiting requested review from harshpurwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackparmer @xarico10